Loading video...

Video Failed to Load

Go Home

Stop using document.removeEventListener() 😤

68,287 views • 1 year ago •via X (Twitter)

11 Comments

Ben Holmes's profile picture
Ben Holmes1 year ago

Thanks for the tip @mattpocockuk

PDF GPT's profile picture
PDF GPT1 year ago

This is my favorite AI tool for reviewing reports. Just upload a report, ask for a summary, and get one in seconds. It's like ChatGPT, but built for documents. Try it for free.

Alex MacArthur's profile picture
Alex MacArthur1 year ago

You can use the same signal to nuke multiple listeners at once too!

samuel 🦋's profile picture
samuel 🦋1 year ago

holy shit thank you for this

José Breijo's profile picture
José Breijo1 year ago

With `removeEventListener`, your codebase has a predictable 1:1 explicit relationship. It is declarative, and that is what it was intended for. Instead, an abortable signal is an optional argument; you need to carry it around, too, and manually kill listeners (malloc PTSD). Fashionable or more terse approaches are cool, but they are not always justified, at least not for me, like lambdas vs. function declarations.

Mantas's profile picture
Mantas1 year ago

I don't know why, but this looks cleaner. Probably because event is removed in same way how it was added, not using some separate abortController object which is then passed as param to addEventListener...

JLarky's profile picture
JLarky1 year ago

The poor whiteboard got out of the frame :-(

Marius Vatasoiu's profile picture
Marius Vatasoiu1 year ago

All good and then you find out you need to support Safari 14 💀

Iván Tajes Vidal's profile picture
Iván Tajes Vidal1 year ago

Just stop using React!

Aaron's profile picture
Aaron1 year ago

I wouldn't say "Stop using", instead, "here's another way to achieve a slightly similar effect but not exactly the same that may or not may not suite your use case" although where's the twitter friendly way on how to communicate that :p

Moshe Schnitzler's profile picture
Moshe Schnitzler1 year ago

Practically speaking, how can pass in a AbortListener to clean my dishes?

Related Videos

Stop Dating Toxic Men!! 😤😤😤😡
0:29

Sensitive content

Stop Dating Toxic Men!! 😤😤😤😡

Patience

194,518 views • 3 months ago