This is why PR diff speed matters. This isn't a dunk on GitHub specifically, because GitLab, Forgejo, etc. are all equal or worse. But this is the kind of thing that drives me nuts, because this is a core workflow and its slow enough I literally take my hands... off the keyboard. Btw, when my mouse jiggles on the left, its because the page is literally skipping frames and I'm instinctively shaking my mouse to see if it'll respond. And on the keyboard input you can literally here me finish typing before a letter even shows up. For someone like me who is an expert at these tools, my brain navigates the tool dramatically faster than it can keep up, and that is not good. The tool should not get in the way.show more

Based and real

Bigger issue for me on big diffs... GH stops rendering past a certain size, you have to click into each file to load. Missed a permission drift in a 4k line terraform PR because of it.

Yeah this video ran into that lol (unplanned)

The internal tools at Meta (Phabricator for code, but also literally every other tool) are ~5x slower than GitHub...on a good day. I literally rip my hair out every single fucking day. I've been driven insane.

Might not seem much to some people but these kinds of delays take your mind off the subject. It's distracting, you lose your state of flow, etc. You should spend as little brain energy as possible on interacting with the diff tool

Neovim 💙. Once PR is fetched, it's instant. It needs some time to get used to, but if you do it every day, why not?

I review all my PR on Linear now their early access version of it is already better than GitHub give it a try

What you think of this approach to code reviews? Something I'm working on, almost ready for release just needs some ui polishing, will be free for public repos, would love some feedback

Build the GitHub replacement you want already pls

This is on the 1 million line zig to rust PR right? I feel like you should mention that.

I just can’t stand bitbucket at work. I just do everything local

Many many years ago I was pairing with a friend of mine. The machine started getting weird, and I turned to him and said "it's about to bluescreen", and moments later it bluescreened. He asked "how the fuck did you know?" and i realized something...

Is Forgejo worse? they put their render time at the bottom of the page, and it’s usually quite fast

I admit I have not tried a million line diff directly in Forgejo, but I've had much smaller diffs load poorly, e.g. where the sidebar loads slowly for file nav. I don't know the keyboard nav to get to it but there doesn't seem to be a "jump to file" i can find either.

That makes sense! I’ll admit I haven’t spent a lot of time in it either, but it feels fast. Running on dedicated infra is usually faster than shared infra, tho I have an instance for myself, running on my tower at home, and even Linux feels snappy:

What's the tool on the right?

@madhavjha Thank you for this man this is awesome!

Still waiting for GitHub to implement folders to organize repos. Seems they are spending all their time on CI features and Copilot. No attention to improving UX or UI performance.

I think the issue here is where you started from, gh was never designed for a million or multiple 1000s line diff, but overtime they added patches on top of it to make it support the growing needs, on the other hand any new tool already knows about these problems so the base is designed differently and more efficiently.

Didja check out ?

tooling shouldnt lag but shouldnt a PR be broken down into smaller pieces long before it hits 1000 lines or 10 files

My bet is their app takes the assumption that people will write many small PRs with smallish files (<500LoC) I feel since engineers started leveraging code generation it started falling apart (Golang has a lot of it), and big AI PRs simply break this even further

Even though I'm not a fan of Microsoft, please be fair about the scale and the current load of the services!!! It's a vital parameter to compare two things.

The one on the right is on top of the GitHub API and client side so it has no bearing. They could ship this if they wanted.

I agree, they can make it faster, GitHub crams every line, comment box, and heavy API call into your browser at once, crushing performance. @diffshub is lightning fast because it simplifies the rendering page and uses virtual scrolling—only rendering what's on your screen! ⚡

GitLab is experimenting with a faster diff btw Demo:

super nice!!! 👏 @pierrecomputer

This is every moment of every day for enterprise software users.

To answer your question «What’s the time difference?» It was 7 sec vs 20 sec, both starting from the search bar on the loaded page.

offtopic but how did you split the tab into two sides?

WTF is happening? they are using nextjs for a website that has no business using that bloated garbage

I agree, though I sympathize with the devs trying not to crash the tab. Both GitHub and GitLab have the "expand" problem, click, wait, click, wait, and it still truncates large diffs. For anything serious, pulling locally is the only reliable option.

This is the same for any interface really. It drives me nuts when the tool I use every day is sluggish. IDEs are a good example of that. Zed was extremely fast when they released it, but now they are doing some update before loading, so you click on the icon and nothing happens for 5 seconds. Jetbrains is obviously 20 times worse.

Try out beta PR support in Linear. All data is still on GitHub, but the UI is much faster. Kind of tells you where GitHub is slow too. Still beta though, some weird bugs when actually using it, but diffs are fast.

Needs to be rebuild from ground up again for the scale.

Have you not noticed that everything is becoming worse? The software is just becoming bloated slow trash incapable of not just working quickly enough but lacking features that were available in older versions? It is a global trend - everything technological is becoming a shit.

Drives me a little nuts every time I see a screen where search is possible and the cursor isn’t dropped in ready for text

GitHub should just acquire diffshub and adopt their tech

huge missed opportunity to wear a beret and smoke a thin cig for this Pierre adulation