Skip navigation
i can't be the only one that finds reviewing code in GitHub next to useless these days?
0:00 / 0:24

i can't be the only one that finds reviewing code in GitHub next to useless these days?

geoff

@GeoffreyHuntley91K followers

Visit on X
122 likesDownloadOriginal post

10,259 views

i can't be the only one that finds reviewing code in GitHub next to useless these days? how can this even be a thing. clicking on a filename doesn't even bring the filename into focus.

32 Comments

Comments from the original post on X (Twitter)

  • Dmitrii Kovanikov's profile picture

    @ChShersh

    As intended. Humans are not supposed to review the code anymore. So the enshittification of the human review process will continue.

    7 likes

  • Mads ♥mann's profile picture

    @Mads_Hartmann

    I have found that if you click twice it scrolls to the correct position 😂

    3 likes

  • geoff's profile picture

    @GeoffreyHuntley

    same, frustrating.

    1 like

  • Ashley Ha's profile picture

    @ashleybchae

    i do it for the vibes now tbh

    1 like

  • geoff's profile picture

    @GeoffreyHuntley

    i start my planning sessions by looking at the code and that starts the journey of carving.

    2 likes

  • Ashley Ha's profile picture

    @ashleybchae

    period

  • Adam Jacob's profile picture

    @adamhjk

    I don’t miss code review in those interfaces at all.

    1 like

  • Ben's profile picture

    @Scrubghetti

    Diffshub is pretty good. I also like ghui when I'm at my machine.

    1 like

  • Dominik Roszkowski's profile picture

    @OrestesGaolin

    imho best way to do it now is via

  • Ian Channing 🦈 @ianchanning.delve.town's profile picture

    @ianchanning

    VS Code GitHub PR extension

  • Sandeep Barhanpure's profile picture

    @sandeepinloop

    The click-to-focus bug is the small part. The review page was built for diffs a person wrote in order. When an agent touches thirty files, what I want first is which files the task actually needed, and GitHub shows them all at the same weight.

  • Adam's profile picture

    @adam_bobowski

    Just look at metrics, sir. no need to read code

  • kevinherron's profile picture

    @kevinherron

    It is beyond broken

  • Saurav Anand's profile picture

    @paradox542

    the diff UI really sucks. I spent 15-20mins on looking for a line of code that was in a different file, just becasue of the highlight.

  • kustrun's profile picture

    @kustrun

    There are some quirks with their preview feature "New Files Changed Experience". Whenever I need to review something on Github I "minimize" all of the files and have only one expended at a time. Kinda stupid, but then it works for a fairly quick check.

  • Stefan Olson's profile picture

    @stefanolson

    Yes, it's awful

  • geoff's profile picture

    @GeoffreyHuntley

    dear @martinwoodward can i need snipe you on behalf of all GitHub users. this really sucks.

  • Martin Woodward's profile picture

    @martinwoodward

    I know the PR crew have some major changes inbound. I’ll check in with them. I was missing what’s going wrong in your screencap above though when I saw it the other day so being super dumb sorry, isn’t it jumping to the file you click on and then showing you the first diff in that file?

    2 likes

  • geoff's profile picture

    @GeoffreyHuntley

    @stefanolson cheers mate. when i click on a file. it doesn’t focus on that file. it selects an el rando file to focus. probs a consistency issue with backend due to load would be my best guess because it comes good eventually without having to refresh frontend state

    1 like

  • Safwan's profile picture

    @safwanyp_

    you gotta double click like its an executable on your pc